Bug 173882

Summary: Move WebsiteDataRecord processing off-thread in WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, buildbot, commit-queue, darin, ggaren, koivisto, rniwa, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173904
https://bugs.webkit.org/show_bug.cgi?id=173895
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-06-27 12:14:54 PDT
Moved processing / filtering of data returned by WebsiteDataStore::fetchData() off the main thread.
Attachments
Patch (15.07 KB, patch)
2017-06-27 13:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.17 KB, patch)
2017-06-27 14:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.22 KB, patch)
2017-06-27 15:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-27 12:15:08 PDT
<rdar://problem/32984366>
Chris Dumez
Comment 2 2017-06-27 13:44:22 PDT
Created attachment 313936 [details] Patch
Build Bot
Comment 3 2017-06-27 13:45:53 PDT
Attachment 313936 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:186: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:189: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:287: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:96: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2017-06-27 14:54:32 PDT
Created attachment 313948 [details] Patch
Chris Dumez
Comment 5 2017-06-27 15:01:36 PDT
Created attachment 313949 [details] Patch
WebKit Commit Bot
Comment 6 2017-06-27 18:47:18 PDT
Comment on attachment 313949 [details] Patch Clearing flags on attachment: 313949 Committed r218860: <http://trac.webkit.org/changeset/218860>
WebKit Commit Bot
Comment 7 2017-06-27 18:47:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.