Bug 173877

Summary: [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bugs-noreply, buildbot
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173874    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch beidson: review+

Description Carlos Garcia Campos 2017-06-27 09:09:51 PDT 
This way IconDatabase and its related classes can be removed from WebCore, as well as the WebKit2 implementation and C API.
Comment 1 Carlos Garcia Campos 2017-06-27 09:15:02 PDT 
Created attachment 313916 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-06-27 09:39:14 PDT 
Created attachment 313919 [details]
Patch

Fix WPE build, I forgot to update the WPE makefile. We should move common glib api files to a shared makefile at some point.
Comment 3 Brady Eidson 2017-06-27 13:14:56 PDT 
Comment on attachment 313919 [details]
Patch

lgtm
Comment 4 Build Bot 2017-06-27 13:32:31 PDT 
Attachment 313919 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/glib/WebKitIconLoadingClient.cpp:36:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2017-06-27 23:04:35 PDT 
(In reply to Brady Eidson from comment #3)
> Comment on attachment 313919 [details]
> Patch
> 
> lgtm

Thanks, could you also review bug #173874 that is blocking this one?
Comment 6 Carlos Garcia Campos 2017-06-29 03:00:36 PDT 
Committed r218922: <http://trac.webkit.org/changeset/218922>