Bug 173877 - [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
Summary: [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 173874
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-27 09:09 PDT by Carlos Garcia Campos
Modified: 2017-06-29 03:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (125.68 KB, patch)
2017-06-27 09:15 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (126.60 KB, patch)
2017-06-27 09:39 PDT, Carlos Garcia Campos 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-27 09:09:51 PDT 
This way IconDatabase and its related classes can be removed from WebCore, as well as the WebKit2 implementation and C API.
Comment 1 Carlos Garcia Campos 2017-06-27 09:15:02 PDT 
Created attachment 313916 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-06-27 09:39:14 PDT 
Created attachment 313919 [details]
Patch

Fix WPE build, I forgot to update the WPE makefile. We should move common glib api files to a shared makefile at some point.
Comment 3 Brady Eidson 2017-06-27 13:14:56 PDT 
Comment on attachment 313919 [details]
Patch

lgtm
Comment 4 Build Bot 2017-06-27 13:32:31 PDT 
Attachment 313919 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/glib/WebKitIconLoadingClient.cpp:36:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2017-06-27 23:04:35 PDT 
(In reply to Brady Eidson from comment #3)
> Comment on attachment 313919 [details]
> Patch
> 
> lgtm

Thanks, could you also review bug #173874 that is blocking this one?
Comment 6 Carlos Garcia Campos 2017-06-29 03:00:36 PDT 
Committed r218922: <http://trac.webkit.org/changeset/218922>