Bug 173838

Summary: [iOS DnD] [WK2] Beginning a drag session should prevent clicking via long press
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226188
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2017-06-26 09:55:56 PDT
After r218579, WebKit no longer attempts to replace out-of-the-box UIKit long-press/drag lift disambiguation by firing events immediately. However, this means that dragging will defer the highlight long press gesture recognizer until dragging ends rather than cancel it immediately, which causes WKContentView to dispatch a synthetic click immediately upon lift. To fix this, we should bail out of the highlight long press gesture when beginning a drag.
Attachments
Patch (2.04 KB, patch)
2017-06-26 10:02 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-06-26 10:02:22 PDT
Created attachment 313849 [details] Patch
WebKit Commit Bot
Comment 2 2017-06-26 10:54:41 PDT
Comment on attachment 313849 [details] Patch Clearing flags on attachment: 313849 Committed r218812: <http://trac.webkit.org/changeset/218812>
WebKit Commit Bot
Comment 3 2017-06-26 10:54:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.