Bug 173825 – [WTF] Drop Thread::create(obsolete things) API since we can use lambda

• Component: New Bugs
• Status: RESOLVED FIXED

[Yusuke Suzuki]

[WTF] Drop Thread::create(obsolete things) API since we can use lambda

[Yusuke Suzuki]

Created attachment 313814 [details]
Patch

[Build Bot]

Attachment 313814 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 313815 [details]
Patch

[Build Bot]

Attachment 313815 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 313816 [details]
Patch

[Build Bot]

Attachment 313816 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 313816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313816&action=review

> Source/WebCore/bindings/js/GCController.cpp:104
> +    RefPtr<Thread> thread = Thread::create("WebCore: GCController", collect);

This is the one not compiling on Windows.

[Yusuke Suzuki]

Created attachment 313818 [details]
Patch

[Build Bot]

Attachment 313818 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 313818 [details]
Patch

r=me

[Yusuke Suzuki]

Comment on attachment 313818 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 313818 [details]
Patch

Clearing flags on attachment: 313818

Committed r218816: <http://trac.webkit.org/changeset/218816>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.