Summary: | Web Inspector: Create a single -webkit-canvas for use inside popovers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, mattbaker | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Devin Rousso
2017-06-25 00:28:30 PDT
Created attachment 314124 [details]
Patch
Comment on attachment 314124 [details]
Patch
r-, because after the change the Quick Open popover no longer has rounded bottom corners. This only occurs when the dialog resizes to show results.
Comment on attachment 314124 [details] Patch (In reply to Matt Baker from comment #2) > Comment on attachment 314124 [details] > Patch > > r-, because after the change the Quick Open popover no longer has rounded > bottom corners. This only occurs when the dialog resizes to show results. This is unrelated. I am seeing this issue without these changes. Furthermore, the Quick Open dialog doesn't even use a popover, so this shouldn't affect it at all. Comment on attachment 314124 [details]
Patch
r=me. This would be a problem if multiple popovers appeared at once, but AFAIK popovers are intended to be modal.
Comment on attachment 314124 [details] Patch Clearing flags on attachment: 314124 Committed r218959: <http://trac.webkit.org/changeset/218959> All reviewed patches have been landed. Closing bug. |