Bug 173820 - Web Inspector: Create a single -webkit-canvas for use inside popovers
Summary: Web Inspector: Create a single -webkit-canvas for use inside popovers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-25 00:28 PDT by Devin Rousso
Modified: 2017-06-29 13:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.24 KB, patch)
2017-06-29 01:05 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-06-25 00:28:30 PDT
It seems ridiculous to create a new -webkit-canvas for each popover.  We should just have one canvas that we resize/redraw each time a popover is shown.
Comment 1 Devin Rousso 2017-06-29 01:05:44 PDT
Created attachment 314124 [details]
Patch
Comment 2 Matt Baker 2017-06-29 10:57:26 PDT
Comment on attachment 314124 [details]
Patch

r-, because after the change the Quick Open popover no longer has rounded bottom corners. This only occurs when the dialog resizes to show results.
Comment 3 Devin Rousso 2017-06-29 11:20:13 PDT
Comment on attachment 314124 [details]
Patch

(In reply to Matt Baker from comment #2)
> Comment on attachment 314124 [details]
> Patch
> 
> r-, because after the change the Quick Open popover no longer has rounded
> bottom corners. This only occurs when the dialog resizes to show results.

This is unrelated.  I am seeing this issue without these changes.  Furthermore, the Quick Open dialog doesn't even use a popover, so this shouldn't affect it at all.
Comment 4 Matt Baker 2017-06-29 12:48:49 PDT
Comment on attachment 314124 [details]
Patch

r=me. This would be a problem if multiple popovers appeared at once, but AFAIK popovers are intended to be modal.
Comment 5 WebKit Commit Bot 2017-06-29 13:15:59 PDT
Comment on attachment 314124 [details]
Patch

Clearing flags on attachment: 314124

Committed r218959: <http://trac.webkit.org/changeset/218959>
Comment 6 WebKit Commit Bot 2017-06-29 13:16:01 PDT
All reviewed patches have been landed.  Closing bug.