Bug 173804 – REGRESSION (AsyncImageDecoding): A tab with the WWDC keynote paused is killed for using excessive power (Image thrashing)

• Component: Images
• Status: RESOLVED FIXED

[Antti Koivisto]

Easy repro in trunk: 
1) https://www.apple.com/apple-events/june-2017/
2) notifyutil -p org.WebKit.lowMemory.begin

[Antti Koivisto]

<rdar://problem/32623745>

[Antti Koivisto]

Created attachment 313874 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 313874 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313874&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:229
> +                imageObserver()->didDraw(*this);

It's confusing, and not very future-proof, to call something called 'didDraw' when we didn't actually draw.

> LayoutTests/fast/images/low-memory-decode.html:15
> +    }, 100);

This will always take 100ms. Consider using shouldBecomeTrue().

[Antti Koivisto]

> It's confusing, and not very future-proof, to call something called
> 'didDraw' when we didn't actually draw.

Actually I'll get rid of this for the patch. It is not needed to fix the bug.
 
> > LayoutTests/fast/images/low-memory-decode.html:15
> > +    }, 100);
> 
> This will always take 100ms. Consider using shouldBecomeTrue().

[Antti Koivisto]

Created attachment 313875 [details]
patch

[Antti Koivisto]

> > > LayoutTests/fast/images/low-memory-decode.html:15
> > > +    }, 100);
> > 
> > This will always take 100ms. Consider using shouldBecomeTrue().

That doesn't work because it would make the test succeed even without code changes.

[Simon Fraser (smfr)]

Comment on attachment 313875 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313875&action=review

> LayoutTests/fast/images/low-memory-decode.html:15
> +    }, 200);

Maybe you can bail if you see > 1 decode.

[Antti Koivisto]

Created attachment 313876 [details]
patch

[Antti Koivisto]

Created attachment 313877 [details]
patch

[Build Bot]

Comment on attachment 313877 [details]
patch

Attachment 313877 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4003307

New failing tests:
fast/images/low-memory-decode.html

[Build Bot]

Created attachment 313881 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 313877 [details]
patch

Attachment 313877 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4003402

New failing tests:
fast/images/low-memory-decode.html

[Build Bot]

Created attachment 313884 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 313885 [details]
patch

[WebKit Commit Bot]

Comment on attachment 313885 [details]
patch

Clearing flags on attachment: 313885

Committed r218826: <http://trac.webkit.org/changeset/218826>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.