Bug 173792

Summary:

Add release assertion to make sure callbackIdentifier is not 0 in DocumentLoader::finishedLoadingIcon()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, buildbot, commit-queue, dbates, ggaren, japhet, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2017-06-23 14:56:46 PDT

Add release assertion to make sure callbackIdentifier is not 0 in DocumentLoader::finishedLoadingIcon() as this could cause HashTable corruption on WebPageProxy side.

Attachments
Patch (4.92 KB, patch) 2017-06-23 14:57 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-06-23 14:57:58 PDT

Created attachment 313749 [details] Patch

Chris Dumez

Comment 2 2017-06-23 14:58:42 PDT

Comment on attachment 313749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313749&action=review > Source/WebCore/loader/DocumentLoader.cpp:1698 > + auto callbackIdentifier = m_iconLoaders.take(&loader); Renamed because loadIdentifier means something else (see DocumentLoader::didGetLoadDecisionForIcon()).

WebKit Commit Bot

Comment 3 2017-06-23 16:24:15 PDT

Comment on attachment 313749 [details] Patch Clearing flags on attachment: 313749 Committed r218775: <http://trac.webkit.org/changeset/218775>

WebKit Commit Bot

Comment 4 2017-06-23 16:24:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.