| Summary: | Add support for different versions of iOS when loading test expectations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, buildbot, commit-queue, dbates, ddkilzer, glenn, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=173107 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 173775 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2017-06-23 10:48:07 PDT
Created attachment 313730 [details]
Patch
Comment on attachment 313730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313730&action=review rs=me. > Tools/Scripts/webkitpy/port/ios_device.py:106 > + if version != device.platform.os_version: I think "device.platform.os_version != version" would be more readable. > Tools/Scripts/webkitpy/port/ios_device.py:107 > + raise RuntimeError('{} has a version of {} which does not match {}'.format(device, device.platform.os_version, version)) This message might be confusing for readers. Should indicate that there are multiple devices connected having different ios versions. > Tools/Scripts/webkitpy/port/ios_device.py:109 > + raise RuntimeError('No devices are available') Can we move this check about "No devices available" before for loop? Created attachment 314183 [details]
Patch
Comment on attachment 314183 [details] Patch Clearing flags on attachment: 314183 Committed r218996: <http://trac.webkit.org/changeset/218996> All reviewed patches have been landed. Closing bug. |