Bug 173774

Summary: Add support for different versions of iOS when loading test expectations
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, buildbot, commit-queue, dbates, ddkilzer, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173107
Bug Depends on:    
Bug Blocks: 173775    
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2017-06-23 10:48:07 PDT
We should support test expectations for different versions of iOS.
Attachments
Patch (5.51 KB, patch)
2017-06-23 11:35 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2017-06-29 16:26 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-23 10:48:43 PDT
<rdar://problem/32951132>
Jonathan Bedard
Comment 2 2017-06-23 11:35:05 PDT
Created attachment 313730 [details] Patch
Aakash Jain
Comment 3 2017-06-29 16:09:05 PDT
Comment on attachment 313730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313730&action=review rs=me. > Tools/Scripts/webkitpy/port/ios_device.py:106 > + if version != device.platform.os_version: I think "device.platform.os_version != version" would be more readable. > Tools/Scripts/webkitpy/port/ios_device.py:107 > + raise RuntimeError('{} has a version of {} which does not match {}'.format(device, device.platform.os_version, version)) This message might be confusing for readers. Should indicate that there are multiple devices connected having different ios versions. > Tools/Scripts/webkitpy/port/ios_device.py:109 > + raise RuntimeError('No devices are available') Can we move this check about "No devices available" before for loop?
Jonathan Bedard
Comment 4 2017-06-29 16:26:52 PDT
Created attachment 314183 [details] Patch
WebKit Commit Bot
Comment 5 2017-06-30 08:33:20 PDT
Comment on attachment 314183 [details] Patch Clearing flags on attachment: 314183 Committed r218996: <http://trac.webkit.org/changeset/218996>
WebKit Commit Bot
Comment 6 2017-06-30 08:33:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.