Bug 173753

Summary: ResourceLoadStatisticsStore should be ThreadSafeRefCounted
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, buildbot, commit-queue, darin, dbates, japhet, kling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-06-22 19:14:57 PDT
ResourceLoadStatisticsStore should be ThreadSafeRefCounted given code like this: void ResourceLoadStatisticsStore::fireDataModificationHandler() { ASSERT(!isMainThread()); RunLoop::main().dispatch([this, protectedThis = makeRef(*this)] () { if (m_dataAddedHandler) m_dataAddedHandler(); }); }
Attachments
Patch (1.45 KB, patch)
2017-06-22 19:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-22 19:16:46 PDT
<rdar://problem/32939326>
Chris Dumez
Comment 2 2017-06-22 19:17:50 PDT
Created attachment 313685 [details] Patch
WebKit Commit Bot
Comment 3 2017-06-22 19:58:06 PDT
Comment on attachment 313685 [details] Patch Clearing flags on attachment: 313685 Committed r218734: <http://trac.webkit.org/changeset/218734>
WebKit Commit Bot
Comment 4 2017-06-22 19:58:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.