Bug 173753

Summary:

ResourceLoadStatisticsStore should be ThreadSafeRefCounted

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, bfulgham, buildbot, commit-queue, darin, dbates, japhet, kling, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2017-06-22 19:14:57 PDT

ResourceLoadStatisticsStore should be ThreadSafeRefCounted given code like this:

void ResourceLoadStatisticsStore::fireDataModificationHandler()
{
    ASSERT(!isMainThread());
    RunLoop::main().dispatch([this, protectedThis = makeRef(*this)] () {
        if (m_dataAddedHandler)
            m_dataAddedHandler();
    });
}

Comment 1 Radar WebKit Bug Importer 2017-06-22 19:16:46 PDT

<rdar://problem/32939326>

Comment 2 Chris Dumez 2017-06-22 19:17:50 PDT

Created attachment 313685 [details]
Patch

Comment 3 WebKit Commit Bot 2017-06-22 19:58:06 PDT

Comment on attachment 313685 [details]
Patch

Clearing flags on attachment: 313685

Committed r218734: <http://trac.webkit.org/changeset/218734>

Comment 4 WebKit Commit Bot 2017-06-22 19:58:08 PDT

All reviewed patches have been landed.  Closing bug.