Summary: | Web Inspector: Use Element.closest for internal code | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, Hironori.Fujii, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | GoodFirstBug, InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Nikita Vasilyev
2017-06-22 16:56:55 PDT
Created attachment 363127 [details]
Patch
I haven't tested every single case, but the ones I did worked fine :)
Comment on attachment 363127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363127&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:2340 > + let contentBrowserElement = this.currentFocusElement.closest("content-browser"); This should be ".content-browser" Created attachment 363137 [details]
Patch
Comment on attachment 363137 [details] Patch Clearing flags on attachment: 363137 Committed r242174: <https://trac.webkit.org/changeset/242174> All reviewed patches have been landed. Closing bug. Comment on attachment 363137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363137&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:536 > + wrapper = selection.focusNode.closest("." + WI.LogContentView.ItemWrapperStyleClassName); selection.focusNode isn't necessarily an Element. Filed: Bug 207248 – [Web Inspector][WinCairo] Selecting an error message in Console causes "TypeError: selection.focusNode.closest is not a function." |