Bug 173740

Summary: RegExpPrototype.js builtin uses for-of iteration which is almost certainly incorrect
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2017-06-22 15:22:14 PDT
Because a user's code could override the default iteration and break our builtin.
Attachments
patch (2.72 KB, patch)
2017-06-26 21:15 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-06-26 21:15:32 PDT
Created attachment 313895 [details] patch
Mark Lam
Comment 2 2017-06-26 21:59:23 PDT
Comment on attachment 313895 [details] patch r=me
WebKit Commit Bot
Comment 3 2017-06-26 22:49:48 PDT
Comment on attachment 313895 [details] patch Clearing flags on attachment: 313895 Committed r218828: <http://trac.webkit.org/changeset/218828>
WebKit Commit Bot
Comment 4 2017-06-26 22:49:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.