Bug 173740 - RegExpPrototype.js builtin uses for-of iteration which is almost certainly incorrect
Summary: RegExpPrototype.js builtin uses for-of iteration which is almost certainly in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 15:22 PDT by Saam Barati
Modified: 2017-06-26 22:49 PDT (History)
11 users (show)

See Also:

Attachments
patch (2.72 KB, patch)
2017-06-26 21:15 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-06-22 15:22:14 PDT 
Because a user's code could override the default iteration and break our builtin.
Comment 1 Saam Barati 2017-06-26 21:15:32 PDT 
Created attachment 313895 [details]
patch
Comment 2 Mark Lam 2017-06-26 21:59:23 PDT 
Comment on attachment 313895 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2017-06-26 22:49:48 PDT 
Comment on attachment 313895 [details]
patch

Clearing flags on attachment: 313895

Committed r218828: <http://trac.webkit.org/changeset/218828>
Comment 4 WebKit Commit Bot 2017-06-26 22:49:49 PDT 
All reviewed patches have been landed.  Closing bug.