Bug 173725

Summary:

REGRESSION: LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout on Sierra

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, graouts, jlewis3, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Ryan Haddad

Reported 2017-06-22 10:41:34 PDT

LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r218702%20(2701)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fplacard-support%2Fplacard-support-pip.html

Attachments
Patch (2.64 KB, patch) 2017-06-22 11:34 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryan Haddad

Comment 1 2017-06-22 10:42:40 PDT

This started yesterday, but I haven't identified the commit that caused it. Antoine, can you take a look at this? It is currently timing out more often than it passes.

Antoine Quint

Comment 2 2017-06-22 11:22:42 PDT

The test enters fullscreen on WK1 rather than picture-in-picture, at least on High Sierra. It looks like something changed in WebCore.

Antoine Quint

Comment 3 2017-06-22 11:34:54 PDT

Created attachment 313645 [details] Patch

Antoine Quint

Comment 4 2017-06-22 11:35:11 PDT

See https://bugs.webkit.org/show_bug.cgi?id=173729 for the fullscreen vs. PiP issue.

WebKit Commit Bot

Comment 5 2017-06-22 15:47:03 PDT

Comment on attachment 313645 [details] Patch Clearing flags on attachment: 313645 Committed r218725: <http://trac.webkit.org/changeset/218725>

WebKit Commit Bot

Comment 6 2017-06-22 15:47:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.