Bug 173680

Summary: Add release assertions help diagnose a hang in CallbackMap
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit2Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, ggaren, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173722
https://bugs.webkit.org/show_bug.cgi?id=173738
Attachments:
Description Flags
Adds assertion cdumez: review+

Ryosuke Niwa
Reported 2017-06-21 16:33:18 PDT
We're seeing a hang inside WebKit::CallbackMap in Safari, and we suspect it could be caused by a hash table corruption. Add release assertions to make sure this hash table isn't used in a non-main thread and empty value isn't used as a key.
Attachments
Adds assertion (1.91 KB, patch)
2017-06-21 16:37 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-21 16:34:59 PDT
<rdar://problem/32911286>
Ryosuke Niwa
Comment 2 2017-06-21 16:37:09 PDT
Created attachment 313564 [details] Adds assertion
Ryosuke Niwa
Comment 3 2017-06-21 19:44:14 PDT
Committed r218676: <http://trac.webkit.org/changeset/218676>
Note You need to log in before you can comment on or make changes to this bug.