Bug 173667

Summary:

Sort EWS Queues alphabetically on Patch page

Product:

WebKit

Reporter:

obinna obike <oobike>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=174477

Attachments:

Description	Flags
Sorted the EWS on the Patch Page	aakash_jain: review-
Added Individual EWS status pages and kept the Original EWS Page.	aakash_jain: review-
Linked the statusbubble page with the individual ews page.	aakash_jain: review-
Sorted the EWS on the Patch Page	none
Sorted the EWS on the Patch Page	none
Sort the EWS Queues on Patch Page	none
updated patch	none
Updated patch	none

Description obinna obike 2017-06-21 14:21:20 PDT

Sorted Patch Queue Names in Alphabetical Order

Comment 1 obinna obike 2017-07-17 15:21:25 PDT

Created attachment 315720 [details]
Sorted the EWS on the Patch Page

Comment 2 obinna obike 2017-07-18 16:11:39 PDT

Created attachment 315850 [details]
Added Individual EWS status pages and kept the Original EWS Page.

I also added a page if its been waiting in Queue and processing hasn't started.

Comment 3 obinna obike 2017-07-18 16:44:10 PDT

Created attachment 315858 [details]
Linked the statusbubble page with the individual ews page.

Comment 4 Aakash Jain 2017-07-31 14:15:07 PDT

Comment on attachment 315720 [details]
Sorted the EWS on the Patch Page

Please clean up the patch and the ChangeLog.

Comment 5 Aakash Jain 2017-07-31 14:17:53 PDT

Comment on attachment 315850 [details]
Added Individual EWS status pages and kept the Original EWS Page.

This patch does a lot of things which are totally unrelated to sorting the status messages. Please have the clean patch doing only what the bug is about. Also when you upload a new patch, please mark this patch as obsolete.

Also, you should not include your local changes you use for debugging in the patch (e.g.: common/net/bugzilla/bugzilla.py).

Comment 6 Aakash Jain 2017-07-31 14:19:25 PDT

Comment on attachment 315858 [details]
Linked the statusbubble page with the individual ews page.

Same comments as above. Please have a clean patch. This patch seems to have a lot of unrelated changes and lot of debugging statements.

Comment 7 obinna obike 2017-08-02 12:02:25 PDT

Created attachment 316981 [details]
Sorted the EWS on the Patch Page

Comment 8 Aakash Jain 2017-08-02 15:39:41 PDT

Comment on attachment 316981 [details]
Sorted the EWS on the Patch Page

View in context: https://bugs.webkit.org/attachment.cgi?id=316981&action=review

> Tools/ChangeLog:3
> +        Unsorted EWS on patch page

Unsorted?

> Tools/ChangeLog:7
> +

Please add the description of changes in ChangeLog. Please see https://webkit.org/contributing-code/#changelog-files

Comment 9 Aakash Jain 2017-08-02 15:43:55 PDT

*** Bug 175043 has been marked as a duplicate of this bug. ***

Comment 10 obinna obike 2017-08-03 14:01:43 PDT

Comment on attachment 316981 [details]
Sorted the EWS on the Patch Page

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 220109)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2017-08-01  obinna obike  <oobike@apple.com>
>+
>+        Sorted EWS on patch page
>+        https://bugs.webkit.org/show_bug.cgi?id=175043
>+
>+        Reviewed by NOBODY (OOPS!).
          Sorted the EWS in alphabetical order on the patch page to make it easier for 
          engineers to find specific EWS.
>+
>+        * QueueStatusServer/handlers/patch.py:
>+        (Patch.get):
>+        * QueueStatusServer/templates/patch.html:
>+
> 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
>Index: Tools/QueueStatusServer/handlers/patch.py
>===================================================================
>--- Tools/QueueStatusServer/handlers/patch.py	(revision 219533)
>+++ Tools/QueueStatusServer/handlers/patch.py	(working copy)
>@@ -44,7 +44,7 @@ class Patch(webapp.RequestHandler):
>             per_queue_statuses = queue_status.get(status.queue_name, [])
>             per_queue_statuses.append(status)
>             queue_status[status.queue_name] = per_queue_statuses
>-
>+        queue_status = sorted(queue_status.items())
>         template_values = {
>             "attachment_id" : attachment_id,
>             "bug_id" : bug_id,
>Index: Tools/QueueStatusServer/templates/patch.html
>===================================================================
>--- Tools/QueueStatusServer/templates/patch.html	(revision 219533)
>+++ Tools/QueueStatusServer/templates/patch.html	(working copy)
>@@ -7,7 +7,7 @@
> <body>
> <h1>
>   Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }})
>-</h1>{% for queue_name, statuses in queue_status.items %}
>+</h1>{% for queue_name, statuses in queue_status %}
> <div class="status-details">
>   <h2>{{ queue_name }}</h2>
>   <ul>{% for status in statuses %}

Comment 11 obinna obike 2017-08-07 10:02:20 PDT

Comment on attachment 316981 [details]
Sorted the EWS on the Patch Page

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 220109)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2017-08-01  obinna obike  <oobike@apple.com>
>+
>+        Sorted EWS on patch page
>+        https://bugs.webkit.org/show_bug.cgi?id=175043
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * QueueStatusServer/handlers/patch.py:
>+        (Patch.get): set queue_status as sorted of queue_status.items()
>+        * QueueStatusServer/templates/patch.html:
          changes queue_status.items to queue_status
>+
> 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
>Index: Tools/QueueStatusServer/handlers/patch.py
>===================================================================
>--- Tools/QueueStatusServer/handlers/patch.py	(revision 219533)
>+++ Tools/QueueStatusServer/handlers/patch.py	(working copy)
>@@ -44,7 +44,7 @@ class Patch(webapp.RequestHandler):
>             per_queue_statuses = queue_status.get(status.queue_name, [])
>             per_queue_statuses.append(status)
>             queue_status[status.queue_name] = per_queue_statuses
>-
>+        queue_status = sorted(queue_status.items())
>         template_values = {
>             "attachment_id" : attachment_id,
>             "bug_id" : bug_id,
>Index: Tools/QueueStatusServer/templates/patch.html
>===================================================================
>--- Tools/QueueStatusServer/templates/patch.html	(revision 219533)
>+++ Tools/QueueStatusServer/templates/patch.html	(working copy)
>@@ -7,7 +7,7 @@
> <body>
> <h1>
>   Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }})
>-</h1>{% for queue_name, statuses in queue_status.items %}
>+</h1>{% for queue_name, statuses in queue_status %}
> <div class="status-details">
>   <h2>{{ queue_name }}</h2>
>   <ul>{% for status in statuses %}

Comment 12 Aakash Jain 2017-08-07 10:05:25 PDT

Did u tried to upload a patch?
Seems like something went wrong.

Comment 13 obinna obike 2017-08-07 11:18:48 PDT

Created attachment 317441 [details]
Sorted the EWS on the Patch Page

Comment 14 obinna obike 2017-08-07 13:53:27 PDT

Created attachment 317458 [details]
Sort the EWS Queues on Patch Page

Comment 15 Aakash Jain 2017-08-07 14:55:54 PDT

Patch looks good, but every line is ending with '\'. Please re-upload.

Comment 16 obinna obike 2017-08-07 15:37:10 PDT

Created attachment 317488 [details]
updated patch

Comment 17 obinna obike 2017-08-07 15:43:10 PDT

Created attachment 317489 [details]
Updated patch

Comment 18 WebKit Commit Bot 2017-08-07 16:33:35 PDT

Comment on attachment 317489 [details]
Updated patch

Clearing flags on attachment: 317489

Committed r220369: <http://trac.webkit.org/changeset/220369>

Comment 19 WebKit Commit Bot 2017-08-07 16:33:37 PDT

All reviewed patches have been landed.  Closing bug.

Comment 20 Radar WebKit Bug Importer 2017-08-07 16:34:22 PDT

<rdar://problem/33765016>

Comment 21 Aakash Jain 2017-08-09 10:58:00 PDT

Updated the server. This changes is now live.