Bug 173649

Summary: Import W3C tests regarding navigation inside sandboxed iframes
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fred.wang, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173651    
Bug Blocks: 173162, 173657    
Attachments:
Description Flags
Patch none

Frédéric Wang (:fredw)
Reported 2017-06-21 06:44:58 PDT
https://github.com/w3c/web-platform-tests/pull/6221
Attachments
Patch (36.96 KB, patch)
2017-06-21 09:21 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2017-06-21 08:07:05 PDT
Hi Youen. I'm trying to update the tests in web-platform-tests/html/semantics/embedded-content/the-iframe-element but import-w3c-tests is now returning weird Python errors. I did not get them when I tried to do that import in bug 173162. Are you aware of any recent changes that could have cause this issue?
Frédéric Wang (:fredw)
Comment 2 2017-06-21 09:21:12 PDT
Created attachment 313522 [details] Patch
youenn fablet
Comment 3 2017-06-21 09:25:34 PDT
Comment on attachment 313522 [details] Patch rs=me. Some of these tests are timing out. Are you planning to fix them in the short term? If not, maybe they could be skipped?
Frédéric Wang (:fredw)
Comment 4 2017-06-21 09:58:24 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 313522 [details] > Patch > > rs=me. > Some of these tests are timing out. > Are you planning to fix them in the short term? > If not, maybe they could be skipped? It seems to be a bug in WebKit (they don't happen on Chromium and Gecko). However, my goal is to check that the navigation is indeed forbidden in these cases so for now I'm happy to keep the text reference. I've moved this to bug 173657
WebKit Commit Bot
Comment 5 2017-06-21 10:08:06 PDT
Comment on attachment 313522 [details] Patch Clearing flags on attachment: 313522 Committed r218639: <http://trac.webkit.org/changeset/218639>
WebKit Commit Bot
Comment 6 2017-06-21 10:08:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.