Bug 173638

Summary:

[MSVC] Fix compilation in CP932 (Shift_JIS) environment

Product:

WebKit

Reporter:

Yoshiaki Jitsukawa <yoshiaki.jitsukawa>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, don.olmstead, Hironori.Fujii

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Yoshiaki Jitsukawa 2017-06-20 21:52:32 PDT

The following sources are encoded in UTF-8 (not ASCII) and cause compilation errors in CP932 (aka Shift_JIS, the default code page of Japanese version Windows).
Source\WebCore\platform\LocalizedStrings.cpp
Tools\TestWebKitAPI\Tests\WTF\StringImpl.cpp
Tools\TestWebKitAPI\Tests\WTF\StringView.cpp

Since MSVC's compiler doesn't do encoding detection, we should explicitly specify the encoding.

Comment 1 Yoshiaki Jitsukawa 2017-06-20 22:11:24 PDT

Created attachment 313492 [details]
patch

Comment 2 WebKit Commit Bot 2017-06-21 10:05:32 PDT

Comment on attachment 313492 [details]
patch

Clearing flags on attachment: 313492

Committed r218638: <http://trac.webkit.org/changeset/218638>

Comment 3 WebKit Commit Bot 2017-06-21 10:05:33 PDT

All reviewed patches have been landed.  Closing bug.