Bug 173631

Summary: Add support for structured serialization of CSS Geometry types
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://drafts.fxtf.org/geometry-1/#structured-serialization
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2017-06-20 17:54:14 PDT
Add support for structured serialization of CSS Geometry types
Attachments
Patch (22.43 KB, patch)
2017-06-20 17:57 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (25.39 KB, patch)
2017-06-20 19:51 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (25.28 KB, patch)
2017-06-20 21:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-06-20 17:57:50 PDT
Created attachment 313462 [details] Patch
Build Bot
Comment 2 2017-06-20 18:00:27 PDT
Attachment 313462 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2471: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2017-06-20 19:51:25 PDT
Created attachment 313475 [details] Patch
Build Bot
Comment 4 2017-06-20 19:53:20 PDT
Attachment 313475 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2504: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5 2017-06-20 21:03:01 PDT
Created attachment 313483 [details] Patch
Build Bot
Comment 6 2017-06-20 21:04:41 PDT
Attachment 313483 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2504: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2017-06-21 13:06:03 PDT
Comment on attachment 313483 [details] Patch Clearing flags on attachment: 313483 Committed r218644: <http://trac.webkit.org/changeset/218644>
WebKit Commit Bot
Comment 8 2017-06-21 13:06:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.