Bug 173630

Summary:

[Curl] ResourceHandleManager violate the class responsibility of ResourceHandle

Product:

WebKit

Reporter:

Basuke Suzuki <Basuke.Suzuki>

Component:

WebCore Misc.

Assignee:

Basuke Suzuki <Basuke.Suzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, Basuke.Suzuki, buildbot, commit-queue, don.olmstead, galpeter, Hironori.Fujii

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

173629

Bug Blocks:

117300, 173963, 173964

Attachments:

Description	Flags
Refactoring	none

Description Basuke Suzuki 2017-06-20 17:40:16 PDT

ResourceHandleManager directly manipulates the ResourceHandle contents, but it should be moved into ResourceHandle and ResourceHandleInternal by themselves.

Comment 1 Basuke Suzuki 2017-06-29 14:18:20 PDT

Created attachment 314164 [details]
Refactoring

This patch is simply move methods and functions from ResourceHandleManager to ResourceHandle if possible. ResourceHandleManager apparently violent the class policy and it takes care of ResourceHandle too much which prevents to improve its own responsibility, which is managing ResourceHandle well.

Comment 2 WebKit Commit Bot 2017-06-29 14:58:59 PDT

Comment on attachment 314164 [details]
Refactoring

Clearing flags on attachment: 314164

Committed r218962: <http://trac.webkit.org/changeset/218962>

Comment 3 WebKit Commit Bot 2017-06-29 14:59:00 PDT

All reviewed patches have been landed.  Closing bug.