Bug 173626

Summary: Add logging to identify when the Page suspends scripted animations
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, rniwa, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173628
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Antoine Quint
Reported 2017-06-20 17:00:24 PDT
Add logging to identify when the Page suspends scripted animations
Attachments
Patch (5.31 KB, patch)
2017-06-20 17:04 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (10.28 KB, patch)
2017-06-20 17:36 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.25 KB, patch)
2017-06-21 10:59 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-06-20 17:04:17 PDT
Created attachment 313456 [details] Patch
Tim Horton
Comment 2 2017-06-20 17:06:37 PDT
Comment on attachment 313456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313456&action=review > Source/WebCore/page/Settings.in:303 > +shouldLogScriptedAnimationControllerSuspensionChange initial=true Maybe initial=false and turn it on in DRT instead?
Antoine Quint
Comment 3 2017-06-20 17:36:35 PDT
Created attachment 313460 [details] Patch
Tim Horton
Comment 4 2017-06-21 10:52:46 PDT
Comment on attachment 313460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313460&action=review > Source/WebKit/mac/WebView/WebPreferences.mm:674 > + [NSNumber numberWithBool:NO], WebKitShouldLogScriptedAnimationControllerSuspensionChangePreferenceKey, You have some objection to the modern @NO like the previous few lines?
Antoine Quint
Comment 5 2017-06-21 10:54:31 PDT
(In reply to Tim Horton from comment #4) > Comment on attachment 313460 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313460&action=review > > > Source/WebKit/mac/WebView/WebPreferences.mm:674 > > + [NSNumber numberWithBool:NO], WebKitShouldLogScriptedAnimationControllerSuspensionChangePreferenceKey, > > You have some objection to the modern @NO like the previous few lines? I do not, just needed a little schooling. Will fix in commit.
Antoine Quint
Comment 6 2017-06-21 10:59:16 PDT
Created attachment 313532 [details] Patch for landing
WebKit Commit Bot
Comment 7 2017-06-21 11:37:06 PDT
Comment on attachment 313532 [details] Patch for landing Clearing flags on attachment: 313532 Committed r218640: <http://trac.webkit.org/changeset/218640>
WebKit Commit Bot
Comment 8 2017-06-21 11:37:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.