Bug 173623

Summary: WebAudioSourceProvider should be thread safe ref counted
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2017-06-20 15:56:03 PDT
WebAudioSourceProvider should be thread safe ref counted since it can be refer from main thread and audio thread.
Attachments
Patch (1.46 KB, patch)
2017-06-20 15:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-06-20 15:58:25 PDT
Created attachment 313449 [details] Patch
youenn fablet
Comment 2 2017-06-20 16:06:35 PDT
This change is needed since we are now calling prepare from the audio thread but we apparently want to call m_client->setFormat from the main thread. Maybe we could make setFormat be ok when called from the audio thread if we would like to stick with RefCounted<>. It seems safer to go with ThreadSafeRefCounted for now.
WebKit Commit Bot
Comment 3 2017-06-20 20:05:42 PDT
Comment on attachment 313449 [details] Patch Clearing flags on attachment: 313449 Committed r218622: <http://trac.webkit.org/changeset/218622>
WebKit Commit Bot
Comment 4 2017-06-20 20:05:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.