Summary: | Set getUserMedia permission to true by default on WTR | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, commit-queue, eric.carlson | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2017-06-20 11:37:26 PDT
Created attachment 313416 [details]
Patch
Comment on attachment 313416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313416&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:607 > +void InjectedBundle::setUserMediaPermissionAsUnset() Nit: maybe “reserUserMediaPermission” instead? (In reply to Eric Carlson from comment #2) > Comment on attachment 313416 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313416&action=review > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:607 > > +void InjectedBundle::setUserMediaPermissionAsUnset() > > Nit: maybe “reserUserMediaPermission” instead? setUserMediaPermissionAsUnset is indeed a poor name. How about unsetUserMediaPermission? Comment on attachment 313416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313416&action=review >>> Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:607 >>> +void InjectedBundle::setUserMediaPermissionAsUnset() >> >> Nit: maybe “reserUserMediaPermission” instead? > > setUserMediaPermissionAsUnset is indeed a poor name. > How about unsetUserMediaPermission? That is better, but "reset" is probably better than "unset". Created attachment 313491 [details]
Fixing name
ping review Comment on attachment 313491 [details] Fixing name Clearing flags on attachment: 313491 Committed r218773: <http://trac.webkit.org/changeset/218773> All reviewed patches have been landed. Closing bug. |