Bug 173610

Summary: Set getUserMedia permission to true by default on WTR
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixing name none

youenn fablet
Reported 2017-06-20 11:37:26 PDT
This will ease running WPT tests
Attachments
Patch (11.66 KB, patch)
2017-06-20 11:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing name (11.60 KB, patch)
2017-06-20 22:11 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-06-20 11:39:19 PDT
Created attachment 313416 [details] Patch
Eric Carlson
Comment 2 2017-06-20 18:58:01 PDT
Comment on attachment 313416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313416&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:607 > +void InjectedBundle::setUserMediaPermissionAsUnset() Nit: maybe “reserUserMediaPermission” instead?
youenn fablet
Comment 3 2017-06-20 19:42:59 PDT
(In reply to Eric Carlson from comment #2) > Comment on attachment 313416 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313416&action=review > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:607 > > +void InjectedBundle::setUserMediaPermissionAsUnset() > > Nit: maybe “reserUserMediaPermission” instead? setUserMediaPermissionAsUnset is indeed a poor name. How about unsetUserMediaPermission?
Eric Carlson
Comment 4 2017-06-20 21:41:30 PDT
Comment on attachment 313416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313416&action=review >>> Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:607 >>> +void InjectedBundle::setUserMediaPermissionAsUnset() >> >> Nit: maybe “reserUserMediaPermission” instead? > > setUserMediaPermissionAsUnset is indeed a poor name. > How about unsetUserMediaPermission? That is better, but "reset" is probably better than "unset".
youenn fablet
Comment 5 2017-06-20 22:11:22 PDT
Created attachment 313491 [details] Fixing name
youenn fablet
Comment 6 2017-06-23 13:59:02 PDT
ping review
WebKit Commit Bot
Comment 7 2017-06-23 16:16:35 PDT
Comment on attachment 313491 [details] Fixing name Clearing flags on attachment: 313491 Committed r218773: <http://trac.webkit.org/changeset/218773>
WebKit Commit Bot
Comment 8 2017-06-23 16:16:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.