Bug 173586

Summary: Web Inspector: change the selected ScopeBarItem on mousedown instead of click
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, nvasilyev
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
mattbaker: review+
Patch none

Devin Rousso
Reported 2017-06-19 22:27:27 PDT
This is currently done in the Elements tab sidebar, and it makes switching between sidebars/filers much faster.
Attachments
Patch (3.74 KB, patch)
2017-06-19 22:31 PDT, Devin Rousso 		mattbaker: review+
DetailsFormatted DiffDiff
Patch (3.76 KB, patch)
2017-06-20 19:34 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-06-19 22:31:00 PDT
Created attachment 313368 [details] Patch
Nikita Vasilyev
Comment 2 2017-06-20 14:35:45 PDT
Switching tabs is also on mousedown; this change makes it more consistent.
Matt Baker
Comment 3 2017-06-20 14:40:31 PDT
Comment on attachment 313368 [details] Patch r=me. Please add a comment to the change log explaining the motivation for the change. I would mention consistency with the tab bar, etc.
Devin Rousso
Comment 4 2017-06-20 19:34:00 PDT
Created attachment 313471 [details] Patch
WebKit Commit Bot
Comment 5 2017-06-20 20:13:21 PDT
Comment on attachment 313471 [details] Patch Clearing flags on attachment: 313471 Committed r218623: <http://trac.webkit.org/changeset/218623>
WebKit Commit Bot
Comment 6 2017-06-20 20:13:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.