Bug 173580

Summary: [GTK] Web Inspector:Add icon for Canvas.svg
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bugs-noreply, buildbot, cgarcia, commit-queue, Hironori.Fujii, inspector-bugzilla-changes
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 138941    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
screenshot with and without applying this change none

Devin Rousso
Reported 2017-06-19 21:06:56 PDT
Add new GTK+ icons for canvas contexts. Canvas.svg Will be added in <https://webkit.org/b/138941> Web Inspector: create canvas content view and details sidebar panel
Attachments
Patch (2.09 KB, patch)
2017-06-22 03:31 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
screenshot with and without applying this change (12.93 KB, image/png)
2017-06-22 03:32 PDT, Fujii Hironori 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-06-21 19:19:18 PDT
Thank you for filing the bug for GTK icons, Devin. I can't see the icon in WebKitGTK+ (trunk@218628). Here is the screenshot. https://twitter.com/fujii0/status/877712085710282753 Could you tell me how to show?
Fujii Hironori
Comment 2 2017-06-21 19:41:46 PDT
I got the answer. 1) Open WebInspector of WebInspector 2) Open Console of the second WebInspector 3) Exec WebInspector.settings.experimentalShowCanvasContextsInResources.value = 1 4) Push Reload button in the first WebInspector
Fujii Hironori
Comment 3 2017-06-21 20:20:25 PDT
(In reply to Fujii Hironori from comment #2) > I got the answer. > > 1) Open WebInspector of WebInspector > 2) Open Console of the second WebInspector > 3) Exec > WebInspector.settings.experimentalShowCanvasContextsInResources.value = 1 > 4) Push Reload button in the first WebInspector Never run this steps. This steps seem to break WebInspector. This is the right steps. 1) Open WebInspector 2) Open Settings tab 3) Press Ctrl+Alt+Shift+D to show Debug setting 4) Enable "Canvas: Show Contexts in Resources Tab" 5) Close WebInspector 6) Open WebInspector again 7) Open Resources tab
Fujii Hironori
Comment 4 2017-06-22 03:31:22 PDT
Created attachment 313607 [details] Patch
Fujii Hironori
Comment 5 2017-06-22 03:32:05 PDT
Created attachment 313608 [details] screenshot with and without applying this change
WebKit Commit Bot
Comment 6 2017-06-22 04:38:54 PDT
Comment on attachment 313607 [details] Patch Clearing flags on attachment: 313607 Committed r218689: <http://trac.webkit.org/changeset/218689>
WebKit Commit Bot
Comment 7 2017-06-22 04:38:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.