Bug 173578

Summary:

[iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, buildbot, commit-queue, megan_gardner, rniwa, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Fix DataInteractionTests.CustomActionSheetPopover	none
Patch for landing	none

Wenson Hsieh

Reported 2017-06-19 20:45:26 PDT

<rdar://problem/32825028>

Attachments
Patch (7.66 KB, patch) 2017-06-19 20:56 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.30 MB, application/zip) 2017-06-19 23:00 PDT, Build Bot	no flags	Details
Fix DataInteractionTests.CustomActionSheetPopover (12.23 KB, patch) 2017-06-19 23:40 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch for landing (12.22 KB, patch) 2017-06-20 00:39 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2017-06-19 20:56:09 PDT

Created attachment 313358 [details] Patch

Wenson Hsieh

Comment 2 2017-06-19 22:09:13 PDT

Hm...I just realized -- this means DataInteractionTests.CustomActionSheetPopover needs to be tweaked, since we're no longer controlling the presentation of the popover. I think there's an adjustment I can make in TestWebKitAPI to ensure that this test still checks that showing a custom action sheet doesn't cause dragging to instantly fail.

Build Bot

Comment 3 2017-06-19 23:00:01 PDT

Comment on attachment 313358 [details] Patch Attachment 313358 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3964325 New failing tests: inspector/canvas/create-canvas-contexts.html

Build Bot

Comment 4 2017-06-19 23:00:02 PDT

Created attachment 313372 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Wenson Hsieh

Comment 5 2017-06-19 23:40:11 PDT

Created attachment 313374 [details] Fix DataInteractionTests.CustomActionSheetPopover

Wenson Hsieh

Comment 6 2017-06-20 00:39:07 PDT

Created attachment 313377 [details] Patch for landing

WebKit Commit Bot

Comment 7 2017-06-20 03:09:08 PDT

Comment on attachment 313377 [details] Patch for landing Clearing flags on attachment: 313377 Committed r218579: <http://trac.webkit.org/changeset/218579>

WebKit Commit Bot

Comment 8 2017-06-20 03:09:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.