Bug 173578 - [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
Summary: [iOS DnD] [WK2] Remove custom logic for disambiguating long press action shee...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-19 20:45 PDT by Wenson Hsieh
Modified: 2017-06-20 03:09 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.66 KB, patch)
2017-06-19 20:56 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.30 MB, application/zip)
2017-06-19 23:00 PDT, Build Bot
no flags Details
Fix DataInteractionTests.CustomActionSheetPopover (12.23 KB, patch)
2017-06-19 23:40 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch for landing (12.22 KB, patch)
2017-06-20 00:39 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-06-19 20:45:26 PDT
<rdar://problem/32825028>
Comment 1 Wenson Hsieh 2017-06-19 20:56:09 PDT
Created attachment 313358 [details]
Patch
Comment 2 Wenson Hsieh 2017-06-19 22:09:13 PDT
Hm...I just realized -- this means DataInteractionTests.CustomActionSheetPopover needs to be tweaked, since we're no longer controlling the presentation of the popover. I think there's an adjustment I can make in TestWebKitAPI to ensure that this test still checks that showing a custom action sheet doesn't cause dragging to instantly fail.
Comment 3 Build Bot 2017-06-19 23:00:01 PDT
Comment on attachment 313358 [details]
Patch

Attachment 313358 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3964325

New failing tests:
inspector/canvas/create-canvas-contexts.html
Comment 4 Build Bot 2017-06-19 23:00:02 PDT
Created attachment 313372 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Wenson Hsieh 2017-06-19 23:40:11 PDT
Created attachment 313374 [details]
Fix DataInteractionTests.CustomActionSheetPopover
Comment 6 Wenson Hsieh 2017-06-20 00:39:07 PDT
Created attachment 313377 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-06-20 03:09:08 PDT
Comment on attachment 313377 [details]
Patch for landing

Clearing flags on attachment: 313377

Committed r218579: <http://trac.webkit.org/changeset/218579>
Comment 8 WebKit Commit Bot 2017-06-20 03:09:09 PDT
All reviewed patches have been landed.  Closing bug.