Summary: | [GCrypt] Drop the AES-CFB support | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, jiewen_tan, mcatanzaro | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 133122 | ||||||||||||
Attachments: |
|
Description
Zan Dobersek
2017-06-19 07:00:42 PDT
Created attachment 313291 [details]
Patch
Comment on attachment 313291 [details] Patch Attachment 313291 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3957659 New failing tests: fast/forms/file/intrinsic-min-width-overrides-width.html Created attachment 313297 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 313301 [details]
Patch
Created attachment 313304 [details]
Patch
For what it's worth this hasn't been discussed yet, but given it's code removal it's simple to provide a starting patch. The idea is that the libgcrypt-based implementation would not, at least initially, support algorithms outside of the Web Crypto specification. Comment on attachment 313304 [details]
Patch
Looks good to me. r=me.
Comment on attachment 313304 [details] Patch Clearing flags on attachment: 313304 Committed r218744: <http://trac.webkit.org/changeset/218744> All reviewed patches have been landed. Closing bug. |