Bug 173534

Summary: Use WTF::Function instead of std::function in WebCore/Modules
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, darin, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-06-18 19:24:49 PDT
Use WTF::Function instead of std::function in WebCore/Modules to avoid copying.
Attachments
Patch (11.41 KB, patch)
2017-06-18 19:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.84 KB, patch)
2017-06-18 21:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.88 KB, patch)
2017-06-19 09:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-18 19:25:41 PDT
Created attachment 313254 [details] Patch
Chris Dumez
Comment 2 2017-06-18 21:33:01 PDT
Created attachment 313261 [details] Patch
WebKit Commit Bot
Comment 3 2017-06-19 08:57:09 PDT
Comment on attachment 313261 [details] Patch Rejecting attachment 313261 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 313261, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: intPeerConnection.cpp patching file Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp patching file Source/WebCore/Modules/mediastream/MediaStreamRegistry.h Hunk #1 FAILED at 28. Hunk #2 succeeded at 57 (offset 1 line). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/mediastream/MediaStreamRegistry.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3958020
Chris Dumez
Comment 4 2017-06-19 09:22:12 PDT
Created attachment 313305 [details] Patch
WebKit Commit Bot
Comment 5 2017-06-19 10:44:23 PDT
Comment on attachment 313305 [details] Patch Clearing flags on attachment: 313305 Committed r218498: <http://trac.webkit.org/changeset/218498>
WebKit Commit Bot
Comment 6 2017-06-19 10:44:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.