Bug 173521

Summary: [WebIDL] Move Touch related bindings in Document to their own IDL file
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch achristensen: review+

Sam Weinig
Reported 2017-06-17 21:38:01 PDT
[WebIDL] Move Touch related bindings in Document to their own IDL file
Attachments
Patch (21.55 KB, patch)
2017-06-17 21:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (21.56 KB, patch)
2017-06-18 10:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (21.80 KB, patch)
2017-06-18 13:17 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (21.80 KB, patch)
2017-06-18 14:48 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (21.82 KB, patch)
2017-06-18 15:02 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (21.84 KB, patch)
2017-06-18 15:19 PDT, Sam Weinig 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-06-17 21:44:17 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2017-06-18 10:38:27 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2017-06-18 13:17:35 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2017-06-18 14:48:32 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2017-06-18 15:02:31 PDT Comment hidden (obsolete)
Sam Weinig
Comment 6 2017-06-18 15:19:21 PDT
Created attachment 313247 [details] Patch
Alex Christensen
Comment 7 2017-06-19 09:00:55 PDT
Comment on attachment 313247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313247&action=review > Source/WebCore/dom/TouchList.h:61 > + m_values.reserveInitialCapacity(touches.size()); Why not just WTFMove touches into m_values?
Sam Weinig
Comment 8 2017-06-19 14:26:44 PDT
(In reply to Alex Christensen from comment #7) > Comment on attachment 313247 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313247&action=review > > > Source/WebCore/dom/TouchList.h:61 > > + m_values.reserveInitialCapacity(touches.size()); > > Why not just WTFMove touches into m_values? Can't move Vector<std::reference_wrapper<Touch>> into Vector<Ref<Touch>>. Thanks for the review.
Sam Weinig
Comment 9 2017-06-19 20:25:47 PDT
Committed r218529: <http://trac.webkit.org/changeset/218529>
Note You need to log in before you can comment on or make changes to this bug.