Bug 173491

Summary: Interpreter methods for mapping between Opcode and OpcodeID need not be instance methods.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, jfbastien, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2017-06-16 13:08:42 PDT
This gets rid of some unnecessary work to get the interpreter pointer.
Attachments
proposed patch. (45.11 KB, patch)
2017-06-16 13:37 PDT, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-06-16 13:37:20 PDT
Created attachment 313122 [details] proposed patch.
Build Bot
Comment 2 2017-06-16 13:38:59 PDT
Attachment 313122 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:195: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2017-06-16 13:45:33 PDT
Comment on attachment 313122 [details] proposed patch. r=me.
Mark Lam
Comment 4 2017-06-16 14:03:16 PDT
Thanks for the review. Landed in r218412: <http://trac.webkit.org/r218412>.
Note You need to log in before you can comment on or make changes to this bug.