Bug 173486

Summary: [iOS] Black frames are sent periodically after switching cameras in a WebRTC call
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, jlewis3, jonlee, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173608
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Making test more robust none

Description youenn fablet 2017-06-16 11:34:50 PDT
Switching cameras in a WebRTC call makes black frames being sent
Comment 1 youenn fablet 2017-06-16 13:03:34 PDT
Created attachment 313117 [details]
Patch
Comment 2 youenn fablet 2017-06-16 13:11:42 PDT
<rdar://problem/32819428>
Comment 3 youenn fablet 2017-06-16 13:13:28 PDT
rdar://problem/32819428
Comment 4 Eric Carlson 2017-06-16 13:49:22 PDT
Comment on attachment 313117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313117&action=review

> LayoutTests/webrtc/video-replace-muted-track.html:24
> +        // Approximatively black pixels.

Nit: Approximatively => Approximately
Comment 5 Build Bot 2017-06-16 13:57:36 PDT
Comment on attachment 313117 [details]
Patch

Attachment 313117 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3943535

New failing tests:
webrtc/video-replace-muted-track.html
Comment 6 Build Bot 2017-06-16 13:57:37 PDT
Created attachment 313127 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-06-16 14:29:45 PDT
Comment on attachment 313117 [details]
Patch

Attachment 313117 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3943652

New failing tests:
webrtc/video-replace-muted-track.html
Comment 8 Build Bot 2017-06-16 14:29:46 PDT
Created attachment 313136 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 9 youenn fablet 2017-06-16 14:42:27 PDT
Created attachment 313142 [details]
Making test more robust
Comment 10 WebKit Commit Bot 2017-06-16 16:16:41 PDT
Comment on attachment 313142 [details]
Making test more robust

Clearing flags on attachment: 313142

Committed r218426: <http://trac.webkit.org/changeset/218426>
Comment 11 WebKit Commit Bot 2017-06-16 16:16:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Matt Lewis 2017-06-19 11:58:32 PDT
This test added for this change is extremely flaky on iOS. 

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r218496%20(2175)/results.html

diff:
--- /Volumes/Data/slave/ios-simulator-10-debug-tests-wk2/build/layout-test-results/webrtc/video-replace-muted-track-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-debug-tests-wk2/build/layout-test-results/webrtc/video-replace-muted-track-actual.txt
@@ -1,3 +1,3 @@
 
-PASS Switching from disabled to enabled track 
+FAIL Switching from disabled to enabled track assert_unreached: Reached unreachable code
Comment 13 Matt Lewis 2017-06-20 17:03:07 PDT
Marked test as Flaky on iOS WK2
https://trac.webkit.org/changeset/218617/webkit
Comment 14 Matt Lewis 2017-06-22 14:17:30 PDT
This test has started to fail on Sierra WK2 and El Capitan WK2 Release.

On iOS the test fails far more than passes.

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r218708%20(1699)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1699