Bug 173486 – [iOS] Black frames are sent periodically after switching cameras in a WebRTC call

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

Switching cameras in a WebRTC call makes black frames being sent

[youenn fablet]

Created attachment 313117 [details]
Patch

[youenn fablet]

<rdar://problem/32819428>

[youenn fablet]

rdar://problem/32819428

[Eric Carlson]

Comment on attachment 313117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313117&action=review

> LayoutTests/webrtc/video-replace-muted-track.html:24
> +        // Approximatively black pixels.

Nit: Approximatively => Approximately

[Build Bot]

Comment on attachment 313117 [details]
Patch

Attachment 313117 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3943535

New failing tests:
webrtc/video-replace-muted-track.html

[Build Bot]

Created attachment 313127 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 313117 [details]
Patch

Attachment 313117 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3943652

New failing tests:
webrtc/video-replace-muted-track.html

[Build Bot]

Created attachment 313136 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[youenn fablet]

Created attachment 313142 [details]
Making test more robust

[WebKit Commit Bot]

Comment on attachment 313142 [details]
Making test more robust

Clearing flags on attachment: 313142

Committed r218426: <http://trac.webkit.org/changeset/218426>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This test added for this change is extremely flaky on iOS. 

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r218496%20(2175)/results.html

diff:
--- /Volumes/Data/slave/ios-simulator-10-debug-tests-wk2/build/layout-test-results/webrtc/video-replace-muted-track-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-debug-tests-wk2/build/layout-test-results/webrtc/video-replace-muted-track-actual.txt
@@ -1,3 +1,3 @@
 
-PASS Switching from disabled to enabled track 
+FAIL Switching from disabled to enabled track assert_unreached: Reached unreachable code

[Matt Lewis]

Marked test as Flaky on iOS WK2
https://trac.webkit.org/changeset/218617/webkit

[Matt Lewis]

This test has started to fail on Sierra WK2 and El Capitan WK2 Release.

On iOS the test fails far more than passes.

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r218708%20(1699)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1699