Bug 173480

Summary:

Make some WebRTC tests easier to debug when failing

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jlewis3, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=172922

Attachments:

Description	Flags
Patch	none
Patch	commit-queue: commit-queue-

youenn fablet

Reported 2017-06-16 10:48:19 PDT

Make some WebRTC tests easier to debug when failing

Attachments
Patch (31.42 KB, patch) 2017-06-16 10:55 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (6.38 KB, patch) 2017-06-19 14:13 PDT, youenn fablet	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-06-16 10:55:57 PDT

Created attachment 313091 [details] Patch

WebKit Commit Bot

Comment 2 2017-06-16 13:24:12 PDT

Comment on attachment 313091 [details] Patch Clearing flags on attachment: 313091 Committed r218408: <http://trac.webkit.org/changeset/218408>

WebKit Commit Bot

Comment 3 2017-06-16 13:24:14 PDT

All reviewed patches have been landed. Closing bug.

Matt Lewis

Comment 4 2017-06-19 14:11:06 PDT

This revision seems to have caused test that were previously either flaky timeouts or passing to start failing on release builds according to the Flakiness Dashboard https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r218500%20(2468)/results.html Test that have become flaky: webrtc/datachannel/basic-tcp.html [Failure] webrtc/datachannel/basic.html [Failure] webrtc/datachannel/datachannel-gc.html [Timeout] https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic-tcp.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fdatachannel-gc.html

youenn fablet

Comment 5 2017-06-19 14:13:00 PDT

Reopening to attach new patch.

youenn fablet

Comment 6 2017-06-19 14:13:01 PDT

Created attachment 313331 [details] Patch

youenn fablet

Comment 7 2017-06-19 14:14:07 PDT

I fixed some test expectations in the patch that gets committed. (In reply to Matt Lewis from comment #4) > This revision seems to have caused test that were previously either flaky > timeouts or passing to start failing on release builds according to the > Flakiness Dashboard > > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r218500%20(2468)/results.html > > > Test that have become flaky: > webrtc/datachannel/basic-tcp.html [Failure] > webrtc/datachannel/basic.html [Failure] > webrtc/datachannel/datachannel-gc.html [Timeout] > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic-tcp.html > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic.html > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fdatachannel-gc.html

WebKit Commit Bot

Comment 8 2017-06-19 14:55:38 PDT

Comment on attachment 313331 [details] Patch Rejecting attachment 313331 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 313331, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 218508 = f69b9419e43c98d8b95e3f4028f4d67efcb18a5a r218509 = 09b0a7779144f6998d359b0f7d1c9163eeba68d8 r218510 = 50bd1d913eae75df3b16b29fd32ffc894cb78c1f r218511 = 7eb47a5221ac9b3dac68e44b1e453aec40667bdb Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3962458

Note You need to log in before you can comment on or make changes to this bug.