Bug 173429

Summary:

Add a JSRunLoopTimer registry in VM.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, fpizlo, jfbastien, keith_miller, msaboff, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	fpizlo: review+, buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-elcapitan	none
patch for landing.	none

Mark Lam

Reported 2017-06-15 13:14:17 PDT

This way, we can be sure we've got every JSRunLoopTimer instance covered if we need to change their run loop (e.g. when setting to the WebThread's run loop). <rdar://problem/31287961>

Attachments
proposed patch. (8.91 KB, patch) 2017-06-15 15:11 PDT, Mark Lam	fpizlo: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.95 MB, application/zip) 2017-06-15 16:35 PDT, Build Bot	no flags	Details
patch for landing. (8.94 KB, patch) 2017-06-15 17:16 PDT, Mark Lam	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2017-06-15 15:11:04 PDT

Created attachment 313017 [details] proposed patch.

Filip Pizlo

Comment 2 2017-06-15 15:36:06 PDT

Comment on attachment 313017 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=313017&action=review r=me > Source/JavaScriptCore/runtime/VM.h:681 > + void registerRunLoop(JSRunLoopTimer*); > + void unregisterRunLoop(JSRunLoopTimer*); Can we rename these to registerRunLoopTimer and unregisterRunLoopTimer?

Mark Lam

Comment 3 2017-06-15 15:36:52 PDT

(In reply to Filip Pizlo from comment #2) > > Source/JavaScriptCore/runtime/VM.h:681 > > + void registerRunLoop(JSRunLoopTimer*); > > + void unregisterRunLoop(JSRunLoopTimer*); > > Can we rename these to registerRunLoopTimer and unregisterRunLoopTimer? Will fix.

Build Bot

Comment 4 2017-06-15 16:34:59 PDT

Comment on attachment 313017 [details] proposed patch. Attachment 313017 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3937930 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2017-06-15 16:35:01 PDT

Created attachment 313024 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Mark Lam

Comment 6 2017-06-15 16:39:53 PDT

The test failures look legit. I will investigate.

Mark Lam

Comment 7 2017-06-15 17:14:51 PDT

(In reply to Mark Lam from comment #6) > The test failures look legit. I will investigate. Found it. In unregisterRunLoopTimer(), I was asserting the opposite of what it's supposed to be. Fixed and let's retest on the EWS.

Mark Lam

Comment 8 2017-06-15 17:16:42 PDT

Created attachment 313032 [details] patch for landing.

WebKit Commit Bot

Comment 9 2017-06-15 21:38:38 PDT

Comment on attachment 313032 [details] patch for landing. Clearing flags on attachment: 313032 Committed r218381: <http://trac.webkit.org/changeset/218381>

WebKit Commit Bot

Comment 10 2017-06-15 21:38:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.