Bug 173428

Summary: [cmake] ADD_PRECOMPILED_HEADER should append OBJECT_DEPENDS, not overwrite it
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2017-06-15 12:25:55 PDT
Right now, if any of source files that are passed to ADD_PRECOMPILED_HEADER have non-empty OBJECT_DEPENDS property (e.g. changed with ADD_SOURCE_DEPENDENCIES call), its value is lost.
Attachments
Patch (1.77 KB, patch)
2017-06-15 12:30 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-06-15 12:30:13 PDT
Created attachment 312999 [details] Patch
Konstantin Tokarev
Comment 2 2017-06-15 14:35:59 PDT
Comment on attachment 312999 [details] Patch Clearing flags on attachment: 312999 Committed r218357: <http://trac.webkit.org/changeset/218357>
Konstantin Tokarev
Comment 3 2017-06-15 14:36:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.