Bug 17339

Summary: JavaScriptCore svn fails to build with gcc 4.3
Product: WebKit Reporter: Bernhard Rosenkraenzer <bero>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
fix darin: review+

Bernhard Rosenkraenzer
Reported 2008-02-13 01:51:05 PST
JavaScriptCore/kjs/interpreter.cpp complains about using the undefined function getpid() -- getpid() is defined in unistd.h which isn't being included.
Attachments
fix (624 bytes, patch)
2008-02-13 01:53 PST, Bernhard Rosenkraenzer 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bernhard Rosenkraenzer
Comment 1 2008-02-13 01:53:29 PST
Created attachment 19107 [details] fix
Darin Adler
Comment 2 2008-02-13 04:06:34 PST
Comment on attachment 19107 [details] fix I don't think PLATFORM(UNIX) is right for this. We probably want this on Mac OS X too. It should be #if !PLATFORM(WIN_OS), as it is in TCMalloc.cpp, and to match the #if in Interpreter::evaluate. I'll take care of this.
Darin Adler
Comment 3 2008-02-13 04:10:42 PST
I had to get rid of a tab that was in the patch. Also, svn-apply-patch didn't understand the patch file so I had to do it by hand. Committed revision 30192.
Note You need to log in before you can comment on or make changes to this bug.