Bug 17339

Summary:

JavaScriptCore svn fails to build with gcc 4.3

Product:

WebKit

Reporter:

Bernhard Rosenkraenzer <bero>

Component:

JavaScriptCore

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
fix	darin: review+

Description Bernhard Rosenkraenzer 2008-02-13 01:51:05 PST

JavaScriptCore/kjs/interpreter.cpp complains about using the undefined function getpid() -- getpid() is defined in unistd.h which isn't being included.

Comment 1 Bernhard Rosenkraenzer 2008-02-13 01:53:29 PST

Created attachment 19107 [details]
fix

Comment 2 Darin Adler 2008-02-13 04:06:34 PST

Comment on attachment 19107 [details]
fix

I don't think PLATFORM(UNIX) is right for this. We probably want this on Mac OS X too. It should be #if !PLATFORM(WIN_OS), as it is in TCMalloc.cpp, and to match the #if in Interpreter::evaluate.

I'll take care of this.

Comment 3 Darin Adler 2008-02-13 04:10:42 PST

I had to get rid of a tab that was in the patch. Also, svn-apply-patch didn't understand the patch file so I had to do it by hand.

Committed revision 30192.