Bug 17339 - JavaScriptCore svn fails to build with gcc 4.3
Summary: JavaScriptCore svn fails to build with gcc 4.3
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Darin Adler
Depends on:
Reported: 2008-02-13 01:51 PST by Bernhard Rosenkraenzer
Modified: 2008-02-13 04:10 PST (History)
0 users

See Also:

fix (624 bytes, patch)
2008-02-13 01:53 PST, Bernhard Rosenkraenzer
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Rosenkraenzer 2008-02-13 01:51:05 PST
JavaScriptCore/kjs/interpreter.cpp complains about using the undefined function getpid() -- getpid() is defined in unistd.h which isn't being included.
Comment 1 Bernhard Rosenkraenzer 2008-02-13 01:53:29 PST
Created attachment 19107 [details]
Comment 2 Darin Adler 2008-02-13 04:06:34 PST
Comment on attachment 19107 [details]

I don't think PLATFORM(UNIX) is right for this. We probably want this on Mac OS X too. It should be #if !PLATFORM(WIN_OS), as it is in TCMalloc.cpp, and to match the #if in Interpreter::evaluate.

I'll take care of this.
Comment 3 Darin Adler 2008-02-13 04:10:42 PST
I had to get rid of a tab that was in the patch. Also, svn-apply-patch didn't understand the patch file so I had to do it by hand.

Committed revision 30192.