Bug 173357

Summary: Add API::InjectedBundle::Client
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, jlewis3, ryanhaddad, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173383    
Bug Blocks: 173358    
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Carlos Garcia Campos
Reported 2017-06-14 02:11:26 PDT
It will be used by the GTK+ port instead of the C API.
Attachments
Patch (18.19 KB, patch)
2017-06-14 02:13 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (18.92 KB, patch)
2017-06-14 02:20 PDT, Carlos Garcia Campos 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-14 02:13:22 PDT
Created attachment 312872 [details] Patch
Carlos Garcia Campos
Comment 2 2017-06-14 02:20:13 PDT
Created attachment 312877 [details] Patch
Carlos Garcia Campos
Comment 3 2017-06-14 09:37:30 PDT
Committed r218263: <http://trac.webkit.org/changeset/218263>
Matt Lewis
Comment 4 2017-06-14 13:41:21 PDT
These API tests are timing out after this revision on macOS: WebKit2.AttributedSubstringForProposedRangeWithImage WebKit2.ContextMenuDownloadHTMLDownloadAttribute WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes WebKit2.DidNotHandleKeyDown WebKit2.FirstResponderScrollingPosition WebKit2.ScrollByLineCommands WebKit2.SpacebarScrolling
WebKit Commit Bot
Comment 5 2017-06-14 13:49:29 PDT
Re-opened since this is blocked by bug 173383
Carlos Garcia Campos
Comment 6 2017-06-14 22:33:17 PDT
(In reply to Matt Lewis from comment #4) > These API tests are timing out after this revision on macOS: > > WebKit2.AttributedSubstringForProposedRangeWithImage > WebKit2.ContextMenuDownloadHTMLDownloadAttribute > WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes > WebKit2.DidNotHandleKeyDown > WebKit2.FirstResponderScrollingPosition > WebKit2.ScrollByLineCommands > WebKit2.SpacebarScrolling So, EWS runs layout tests but not api tests? I'm sorry about these failures, I'll investigate them.
Carlos Garcia Campos
Comment 7 2017-06-14 23:27:45 PDT
(In reply to Carlos Garcia Campos from comment #6) > (In reply to Matt Lewis from comment #4) > > These API tests are timing out after this revision on macOS: > > > > WebKit2.AttributedSubstringForProposedRangeWithImage > > WebKit2.ContextMenuDownloadHTMLDownloadAttribute > > WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes > > WebKit2.DidNotHandleKeyDown > > WebKit2.FirstResponderScrollingPosition > > WebKit2.ScrollByLineCommands > > WebKit2.SpacebarScrolling > > So, EWS runs layout tests but not api tests? I'm sorry about these failures, > I'll investigate them. So, those tests are the only ones that use createContextWithInjectedBundle() directly, they are not named tests, which means they don't call WKBundleSetClient(). I've checked the patch and I forgot to initialize the client in InjectedBundle constructor, so it must be it, but I haven't checked it yet. I'll try to test it in a macOS to be sure.
Carlos Garcia Campos
Comment 8 2017-06-14 23:58:37 PDT
Ok, that was indeed the problem. I'll land the fixed patch and keep watching the bots. $ Tools/Scripts/run-api-tests WebKit2.AttributedSubstringForProposedRangeWithImage WebKit2.ContextMenuDownloadHTMLDownloadAttribute WebKit2.DidNotHandleKeyDown WebKit2.FirstResponderScrollingPosition WebKit2.ScrollByLineCommands WebKit2.SpacebarScrolling Running build-api-tests PASS WebKit2.AttributedSubstringForProposedRangeWithImage PASS WebKit2.ContextMenuDownloadHTMLDownloadAttribute PASS WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes PASS WebKit2.DidNotHandleKeyDown PASS WebKit2.FirstResponderScrollingPosition PASS WebKit2.ScrollByLineCommands PASS WebKit2.SpacebarScrolling
Carlos Garcia Campos
Comment 9 2017-06-15 00:02:58 PDT
Committed r218319: <http://trac.webkit.org/changeset/218319>
Note You need to log in before you can comment on or make changes to this bug.