Bug 173327

Summary:

Web Inspector: Send context attributes for tracked canvases

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, dino, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mattbaker, msaboff, saam, webkit-bug-importer

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=173931

Bug Depends on:

138941

Bug Blocks:

Attachments:

Description	Flags
[Patch] WIP	hi: commit-queue-
[Image] After Patch is applied	none
Patch	joepeck: review+
Patch	none

Description Devin Rousso 2017-06-13 13:50:53 PDT

WebGL canvases are able to provide attributes that effect the functionality of the canvas.  The value of these attributes should be visible in the frontend.

Comment 1 Devin Rousso 2017-06-13 13:53:25 PDT

Created attachment 312802 [details]
[Patch] WIP

Comment 2 Devin Rousso 2017-06-13 13:53:38 PDT

Created attachment 312803 [details]
[Image] After Patch is applied

Comment 3 Devin Rousso 2017-06-20 00:08:44 PDT

Created attachment 313375 [details]
Patch

Comment 4 Joseph Pecoraro 2017-06-20 14:02:48 PDT

Comment on attachment 313375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313375&action=review

> LayoutTests/inspector/canvas/context-attributes-expected.txt:13
> +{"alpha":true,"depth":true,"stencil":false,"antialias":true,"premultipliedAlpha":true,"preserveDrawingBuffer":false,"failIfMajorPerformanceCaveat":false}

We could JSON.stringify(obj, null, 2) to make this easier to read.

> Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js:221
> +            const columns = {
> +                name: {title: WebInspector.UIString("Name")},
> +                value: {title: WebInspector.UIString("Value"), width: "30%"},
> +            };
> +            dataGrid = this._attributesDataGridRow.dataGrid = new WebInspector.DataGrid(columns);

Style: Again I think we should inline these as the last param. It looks very awkward like this!

Comment 5 Devin Rousso 2017-06-20 16:28:22 PDT

Created attachment 313453 [details]
Patch

Comment 6 WebKit Commit Bot 2017-06-20 17:07:45 PDT

Comment on attachment 313453 [details]
Patch

Clearing flags on attachment: 313453

Committed r218618: <http://trac.webkit.org/changeset/218618>

Comment 7 WebKit Commit Bot 2017-06-20 17:07:47 PDT

All reviewed patches have been landed.  Closing bug.