Bug 173322

Summary: Refactor AbsenceOfSetter to AbsenceOfSetEffects
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, keith_miller, mark.lam, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Description Michael Saboff 2017-06-13 12:49:15 PDT
The fix to <https://bugs.webkit.org/show_bug.cgi?id=173321> - "DFG doesn't properly handle a property that is change to read only in a prototype" is to add a check for ReadOnly to the AbsenceOfSetter in PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint().  Talking to Phil Pizlo it makes sense to reflect the changed functionality in the name of AbsenceOfSetter in all of it's uses.
Comment 1 Michael Saboff 2017-06-13 15:10:17 PDT
Settled on AbsenceOfSetEffects.
Comment 2 Michael Saboff 2017-06-13 15:13:57 PDT
Created attachment 312816 [details]
Patch
Comment 3 Filip Pizlo 2017-06-13 15:14:48 PDT
Comment on attachment 312816 [details]
Patch

r=me
Comment 4 Michael Saboff 2017-06-13 15:39:36 PDT
Committed r218218: <http://trac.webkit.org/changeset/218218>