Summary: | [JSC] Create JSSet constructor that accepts it's size as parameter | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||||||
Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Caio Lima
2017-06-12 19:14:45 PDT
Created attachment 317538 [details]
Patch
Comment on attachment 317538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review r=me > Source/JavaScriptCore/runtime/HashMapImpl.h:303 > + HashMapImpl(VM& vm, Structure* structure, uint32_t size) Nit: Lets call this "expectedSize" or "sizeHint" to give a better intention of what it is. Comment on attachment 317538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review > Source/JavaScriptCore/ChangeLog:9 > + This patch is adding a new constructor to JSSet that defines its > + initial size. It is important to avoid re-hashing and mutiple Nit: It doesn't define its initial size. It gives an expected initial size. Comment on attachment 317538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Crate JSSet constructor that accepts it's size as parameter typo: /Crate/Create/. Created attachment 317651 [details]
Patch for landing
Created attachment 317669 [details]
Patch for landing
Rebasing with master
Created attachment 317700 [details]
Patch for landing
Fixing ChangeLog
Comment on attachment 317700 [details] Patch for landing Clearing flags on attachment: 317700 Committed r220500: <http://trac.webkit.org/changeset/220500> All reviewed patches have been landed. Closing bug. |