Bug 173297

Summary: [JSC] Create JSSet constructor that accepts it's size as parameter
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
saam: review+
Patch for landing
none
Patch for landing
none
Patch for landing none

Caio Lima
Reported 2017-06-12 19:14:45 PDT
...
Attachments
Patch (3.87 KB, patch)
2017-08-07 21:10 PDT, Caio Lima 		saam: review+
DetailsFormatted DiffDiff
Patch for landing (3.59 KB, patch)
2017-08-08 17:00 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.72 KB, patch)
2017-08-08 20:27 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.61 KB, patch)
2017-08-09 08:03 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2017-08-07 21:10:05 PDT
Created attachment 317538 [details] Patch
Saam Barati
Comment 2 2017-08-07 21:35:03 PDT
Comment on attachment 317538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review r=me > Source/JavaScriptCore/runtime/HashMapImpl.h:303 > + HashMapImpl(VM& vm, Structure* structure, uint32_t size) Nit: Lets call this "expectedSize" or "sizeHint" to give a better intention of what it is.
Saam Barati
Comment 3 2017-08-07 21:36:38 PDT
Comment on attachment 317538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review > Source/JavaScriptCore/ChangeLog:9 > + This patch is adding a new constructor to JSSet that defines its > + initial size. It is important to avoid re-hashing and mutiple Nit: It doesn't define its initial size. It gives an expected initial size.
Mark Lam
Comment 4 2017-08-08 12:17:06 PDT
Comment on attachment 317538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Crate JSSet constructor that accepts it's size as parameter typo: /Crate/Create/.
Caio Lima
Comment 5 2017-08-08 17:00:11 PDT
Created attachment 317651 [details] Patch for landing
Caio Lima
Comment 6 2017-08-08 20:27:19 PDT
Created attachment 317669 [details] Patch for landing Rebasing with master
Caio Lima
Comment 7 2017-08-09 08:03:35 PDT
Created attachment 317700 [details] Patch for landing Fixing ChangeLog
WebKit Commit Bot
Comment 8 2017-08-09 17:42:27 PDT
Comment on attachment 317700 [details] Patch for landing Clearing flags on attachment: 317700 Committed r220500: <http://trac.webkit.org/changeset/220500>
WebKit Commit Bot
Comment 9 2017-08-09 17:42:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-08-09 17:43:21 PDT
<rdar://problem/33816652>
Note You need to log in before you can comment on or make changes to this bug.