Bug 173280

Summary:

[WK2][macOS] Allow AppleEvents for the Citrix Viewer Plugin

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit2

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, beidson, bfulgham, commit-queue, ddkilzer, ggaren

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ap: review+

Brent Fulgham

Reported 2017-06-12 16:10:32 PDT

The plugin process should allow AppleEvents. Since the Plugin Process is generally not sandboxed, this doesn't introduce any new security risks.

Attachments
Patch (2.32 KB, patch) 2017-06-12 16:17 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (2.26 KB, patch) 2017-06-12 16:44 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (1.76 KB, patch) 2017-06-13 10:27 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (1.72 KB, patch) 2017-06-13 13:36 PDT, Brent Fulgham	ap: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2017-06-12 16:11:27 PDT

<rdar://problem/31913624>

Brent Fulgham

Comment 2 2017-06-12 16:17:15 PDT

Created attachment 312717 [details] Patch

Brent Fulgham

Comment 3 2017-06-12 16:41:48 PDT

Comment on attachment 312717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312717&action=review > Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:34 > +#import <wtf/text/WTFString.h> This line isn't needed.

Brent Fulgham

Comment 4 2017-06-12 16:44:37 PDT

Created attachment 312728 [details] Patch

Alexey Proskuryakov

Comment 5 2017-06-12 18:53:16 PDT

Comment on attachment 312728 [details] Patch iOS EWS is red.

Brady Eidson

Comment 6 2017-06-12 19:19:01 PDT

(In reply to Brent Fulgham from comment #0) > The plugin process should allow AppleEvents. Why.

Brent Fulgham

Comment 7 2017-06-12 21:18:31 PDT

(In reply to Brady Eidson from comment #6) > (In reply to Brent Fulgham from comment #0) > > The plugin process should allow AppleEvents. > > Why. See rdar

Brent Fulgham

Comment 8 2017-06-13 10:27:24 PDT

Created attachment 312785 [details] Patch

Alexey Proskuryakov

Comment 9 2017-06-13 10:38:30 PDT

Comment on attachment 312785 [details] Patch r=me assuming that this fix was confirmed to work by testing.

WebKit Commit Bot

Comment 10 2017-06-13 11:39:29 PDT

Comment on attachment 312785 [details] Patch Clearing flags on attachment: 312785 Committed r218187: <http://trac.webkit.org/changeset/218187>

WebKit Commit Bot

Comment 11 2017-06-13 11:39:31 PDT

All reviewed patches have been landed. Closing bug.