Summary: | Screen sleeps while doing WebRTC video | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jonlee, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jer Noble
2017-06-12 15:20:45 PDT
Created attachment 312710 [details]
Patch
Comment on attachment 312710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312710&action=review > Source/WebCore/html/HTMLMediaElement.cpp:6362 > + if (m_mediaStreamSrcObject) { > + // Do not block system from sleeping if element is only rendering local (capture) sources. > + if (WTF::allOf(m_mediaStreamSrcObject->getTracks(), [] (RefPtr<MediaStreamTrack>& track) { > + return track && track->isCaptureTrack(); > + })) > + return SleepType::None; > + } Nit: This indentation is confusing, even though it is technically correct. It would be much easier to understand if the allOf was on a single line: if (WTF::allOf(m_mediaStreamSrcObject->getTracks(), [] (RefPtr<MediaStreamTrack>& track) { return track && track->isCaptureTrack(); })) return SleepType::None; Created attachment 312712 [details]
Patch for landing
Comment on attachment 312712 [details] Patch for landing Clearing flags on attachment: 312712 Committed r218151: <http://trac.webkit.org/changeset/218151> All reviewed patches have been landed. Closing bug. |