Bug 173269

Summary: Seeking an MSE video will begin playing audio long before rendering video
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jlewis3, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173331
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2017-06-12 13:00:59 PDT
Seeking an MSE video will begin playing audio long before rendering video
Attachments
Patch (11.72 KB, patch)
2017-06-12 13:25 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.96 KB, patch)
2017-06-12 15:16 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.96 KB, patch)
2017-06-12 15:42 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-06-12 13:25:01 PDT
Created attachment 312688 [details] Patch
Eric Carlson
Comment 2 2017-06-12 13:43:18 PDT
Comment on attachment 312688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312688&action=review > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:440 > + if (!CFEqual(kCMSampleBufferConsumerNotification_BufferConsumed, notificationName)) Nit: kCMSampleBufferConsumerNotification_BufferConsumed should be soft linked. > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:983 > + CMSetAttachment(sampleCopy.get(), kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed, @{kBufferConsumedContext: context.get()}, kCMAttachmentMode_ShouldNotPropagate); Nit: ditto for kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed.
Jer Noble
Comment 3 2017-06-12 15:16:06 PDT
Created attachment 312707 [details] Patch for landing
Jer Noble
Comment 4 2017-06-12 15:17:28 PDT
<rdar://problem/32448773>
Radar WebKit Bug Importer
Comment 5 2017-06-12 15:17:58 PDT
<rdar://problem/32723702>
Jon Lee
Comment 6 2017-06-12 15:30:32 PDT
<rdar://problem/32448773>
Jer Noble
Comment 7 2017-06-12 15:42:48 PDT
Created attachment 312711 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-06-12 15:57:22 PDT
Comment on attachment 312711 [details] Patch for landing Clearing flags on attachment: 312711 Committed r218150: <http://trac.webkit.org/changeset/218150>
WebKit Commit Bot
Comment 9 2017-06-12 15:57:23 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 10 2017-06-12 17:11:06 PDT
Follow-up build fix: https://trac.webkit.org/changeset/218158/webkit
Note You need to log in before you can comment on or make changes to this bug.