Bug 173254

Summary: [GTK] Prefer to use private WebKitWebView API over WebKitWebViewBase
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173251    
Bug Blocks:    
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2017-06-12 03:28:10 PDT
WebKitWebViewBase is specific to the GTK+ API, but WebKitWebView should be present in any glib-based API.
Attachments
Patch (19.98 KB, patch)
2017-06-12 03:31 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-12 03:31:14 PDT
Created attachment 312649 [details] Patch
Build Bot
Comment 2 2017-06-12 03:32:03 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2017-06-12 05:59:01 PDT
Committed r218098: <http://trac.webkit.org/changeset/218098>
Note You need to log in before you can comment on or make changes to this bug.