Bug 173249

Summary: [GTK] Move WebKit GType macros to WTF
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, berto, bugs-noreply, buildbot, cdumez, cmarcelo, dbates, gustavo, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2017-06-12 01:58:17 PDT 
Moving to a shared place where they could be shared by all ports using a glib-based API. Moved to WTF instead of platform/PAL because they will also be used by JavaScriptCore glib bindings.
Comment 1 Carlos Garcia Campos 2017-06-12 02:01:42 PDT 
Created attachment 312642 [details]
Patch
Comment 2 Build Bot 2017-06-12 02:04:43 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Build Bot 2017-06-12 02:04:50 PDT 
Attachment 312642 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/glib/WebKitGType.h:74:  g_define_type_id__volatile is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/glib/WebKitGType.h:76:  g_define_type_id is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Zan Dobersek 2017-06-12 04:55:22 PDT 
Comment on attachment 312642 [details]
Patch

It looks OK. WEBKIT prefixes seem a bit strange for code that's located in WTF though.
Comment 5 Carlos Garcia Campos 2017-06-12 05:03:10 PDT 
(In reply to Zan Dobersek from comment #4)
> Comment on attachment 312642 [details]
> Patch
> 
> It looks OK. WEBKIT prefixes seem a bit strange for code that's located in
> WTF though.

Yes, they are currently helpers for glib based APIs that use WebKit prefix. They can be renamed to use WTF prefix once the JSC glib bindings are added, since we will not use WebKit prefix there.
Comment 6 Carlos Garcia Campos 2017-06-12 05:50:50 PDT 
Committed r218096: <http://trac.webkit.org/changeset/218096>