| Summary: | Remove WebCore::unloadModule and related data types. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daewoong Jang <daewoong.jang> | ||||||||
| Component: | WebCore Misc. | Assignee: | Daewoong Jang <daewoong.jang> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, buildbot, commit-queue, darin, ysuzuki | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Daewoong Jang
2017-06-10 17:22:44 PDT
Created attachment 312584 [details]
patch
Attachment 312584 [details] did not pass style-queue:
ERROR: Source/WebKit/win/Plugins/PlatformModule.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/WebKit/win/Plugins/PlatformModule.h:31: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 59 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 312585 [details]
patch
Comment on attachment 312585 [details] patch Rejecting attachment 312585 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 312585, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit b90d219..833b332 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 218124 = b90d21939d2d5b208d4f93a6216c4e6da6371e12 r218125 = 833b332e555b3a26b082e77c3d3ff6002970c885 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3918795 Created attachment 312723 [details]
rebased patch
Comment on attachment 312723 [details] rebased patch Clearing flags on attachment: 312723 Committed r218160: <http://trac.webkit.org/changeset/218160> All reviewed patches have been landed. Closing bug. |