Bug 173228

Summary: [JSC] Avoid code bloating for iteration if block does not have "break"
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2017-06-10 11:19:47 PDT
for-of iteration emits code path for break. But we can easily ensure that the given for-of does not have "break". If we ensure that the given block does not have "break" we should not emit this code path.
Attachments
Patch (10.51 KB, patch)
2017-08-16 02:39 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-08-16 02:39:39 PDT
Created attachment 318245 [details] Patch
Keith Miller
Comment 2 2017-08-16 13:16:43 PDT
Comment on attachment 318245 [details] Patch r=me.
Yusuke Suzuki
Comment 3 2017-08-17 04:45:48 PDT
Comment on attachment 318245 [details] Patch Thanks!
WebKit Commit Bot
Comment 4 2017-08-17 05:15:52 PDT
Comment on attachment 318245 [details] Patch Clearing flags on attachment: 318245 Committed r220852: <http://trac.webkit.org/changeset/220852>
WebKit Commit Bot
Comment 5 2017-08-17 05:15:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-08-17 05:16:57 PDT
<rdar://problem/33938501>
Note You need to log in before you can comment on or make changes to this bug.